Skip to content

Conversation

@twz123
Copy link

@twz123 twz123 commented Sep 16, 2021

Issue #, if available:

Description of changes:
ServiceAccounts are namespaced resources, so they should be placed in the chart's destination namespace.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ServiceAccounts are namespaced resources, so they should be placed in
the chart's destination namespace.
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: twz123
To complete the pull request process, please assign a-hilaly after the PR has been reviewed.
You can assign the PR to them by writing /assign @a-hilaly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 16, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 16, 2021

Hi @twz123. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vijtrip2
Copy link
Contributor

Hi @twz123 , Thank you for your PR. These controllers are auto-generated from code-generator library. So, I will request you for making a change in this template file and then next release will have this feature included.

Closing this PR. We appreciate your contribution. 🥇

@vijtrip2 vijtrip2 closed this Sep 16, 2021
twz123 added a commit to twz123/code-generator that referenced this pull request Sep 17, 2021
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this pull request Sep 21, 2021
Issue #, if available:

Description of changes:
* Add name to containerPort (aws-controllers-k8s/s3-controller#48)
* Add namespace to ServiceAccount (aws-controllers-k8s/s3-controller#47)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants