fix(installer): fix installer system installs #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
changed the title
lucaseck
force-pushed
the
fix_installer_system_scope
branch
from
c364f4e to
9691013
Compare
lucaseck
force-pushed
the
fix_installer_system_scope
branch
from
9691013 to
8c159a0
Compare
edwards-aws
requested changes
Jan 9, 2025
Signed-off-by: Lucas Eckhardt <117225985+lucaseck@users.noreply.github.com>
lucaseck
force-pushed
the
fix_installer_system_scope
branch
from
eb3dae7 to
9fd205c
Compare
|
epmog
approved these changes
Jan 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #197
What was the problem/requirement? (What/Why)
The installer was not installing deadline cloud for Houdini correctly when doing a system wide install. The package file was only ever being placed in the default Houdini user pref directory.
What was the solution? (How)
Swapped the installer component to use the env var
HOUDINI_PACKAGE_DIRso that both user and system installs work. A nice additional benefit is that we don't have to have multiple subcomponents to select for each version of Houdini anymore.What is the impact of this change?
Future installers will work to install Deadline Cloud for Houdini with both user and system installations.
How was this change tested?
Manually built both Windows and Linux installers and:
On just Windows I verified that I could install over an existing installation with the current method of putting the package file in the default user pref directory. The previous installation package file was deleted from the default user pref directory. The new installation then set HOUDINI_PACKAGE_DIR. Verified in Houdini's Asset Manager that the correct path to the Node definition was being picked up.
Yes
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.