Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add WaiterConfig to ssm command waiter #152

Merged

Conversation

moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

  1. Worker installation/configuration is taking more than 100 seconds which is the default timeout for the waiter. This results in a -1 exit code being returned despite the command completing successfully.

  2. The pip upgrade command for windows is not completing successfully.

What was the solution? (How)

  1. Add a WaiterConfig to increase the timeout
  2. Use python -m to upgrade pip

What is the impact of this change?

Resolves errors that were happening during the worker configuration and installation

How was this change tested?

Tested using the Worker E2E tests

hatch run e2e-test

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Charles Moore <moorec@amazon.com>
@moorec-aws moorec-aws requested a review from a team as a code owner September 16, 2024 17:45
Copy link

sonarcloud bot commented Sep 16, 2024

Copy link

@leongdl leongdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moorec-aws moorec-aws merged commit 65b93ea into aws-deadline:mainline Sep 16, 2024
15 checks passed
@moorec-aws moorec-aws deleted the moorec/fix-worker-config branch September 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants