feat: reset mqtt3 client on config change #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Sep 29, 2023
src/main/java/com/aws/greengrass/mqtt/bridge/clients/LocalMqtt5Client.java
Show resolved
Hide resolved
jcosentino11
force-pushed
the
reset-mqtt3-client-on-config
branch
from
ec73554 to
8850595
Compare
jcosentino11
force-pushed
the
reset-mqtt3-client-on-config
branch
3 times, most recently
from
66bf52a to
4f29c31
Compare
robcmann
previously approved these changes
Nov 8, 2023
MikeDombo
reviewed
Nov 8, 2023
src/main/java/com/aws/greengrass/mqtt/bridge/clients/LocalMqtt5Client.java
Show resolved
Hide resolved
vabhasin
previously approved these changes
Nov 8, 2023
jcosentino11
force-pushed
the
reset-mqtt3-client-on-config
branch
4 times, most recently
from
623efbc to
565a971
Compare
jcosentino11
force-pushed
the
reset-mqtt3-client-on-config
branch
from
565a971 to
4c69f37
Compare
|
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4c69f37 |
MikeDombo
approved these changes
Nov 8, 2023
sameerzuberi
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Reset MQTTClient when configuration changes, rather than reinstalling bridge.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.