feat: ssl for mqtt3 integ tests #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcosentino11
changed the title
jcosentino11
changed the title
jcosentino11
force-pushed
the
integ-mqtt3-ssl
branch
from
4a51b67 to
cc6719b
Compare
jcosentino11
force-pushed
the
integ-mqtt3-ssl
branch
from
cc6719b to
7a89c0c
Compare
|
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8b0d749 |
robcmann
reviewed
Nov 8, 2023
| @@ -74,7 +74,7 @@ | |||
| <dependency> | |||
| <groupId>io.moquette</groupId> | |||
| <artifactId>moquette-broker</artifactId> | |||
| <version>0.15</version> | |||
| <version>0.17</version> | |||
There was a problem hiding this comment.
Does this break backwards compatibility?
There was a problem hiding this comment.
Never mind, I see the scope now.
robcmann
approved these changes
Nov 8, 2023
MikeDombo
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Configure SSL for Moquette within bridge's integration test extension. This allows us to test SSL communication between bridge's local MQTT3 client and Moquette.
The Moquette version used for integ tests has also been bumped from 0.15 to 0.17, to match the latest version used in the public Greengrass Moquette component.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.