-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW edits to text and diagram #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In guide/content/images/abi-crowdstrike-architecture-diagram.png, Any reason why these are removed?
- the connecting line which denotes a target relationship between the cx eventbridge and CrowdStrike eventbus
- the line that denotes trust between cx iam role and CrowdStrike iam role.
Also please fix the gap in the border of Primary Region
Hi @ryanjpayne, I removed the lines to simplify the image, but I can add them back. Also, thanks for the feedback on the gap. I'll fix these items right now. |
@ryanjpayne - take a look at the updated diagram, and let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The eventbridge arrows are a tad misleading, if we can make them all connect at a higher level then point to the event bus (like in my original diagram) I think that would be more accurate. Also the IAM role arrows make the spacing awkward in the CrowdStrike box. Can we spread that out or use the method I used and have them connect outside the box? Finally, I think Stacksets should be in the primary region box. Thanks!
@ryanjpayne - let me know what you think of the updated diagram. Thanks again for all your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you!
guide/content/_index.md
Outdated
--- | ||
|
||
# CrowdStrike Falcon Horizon | ||
|
||
The purpose of this document is to walk you through the process of onboarding your AWS Organization with CrowdStrike Falcon Horizon. This document is intended for Customers who are using the CrowdStrike Falcon Horizon AWS Built In program(ABI) and in process of building an ABI project. | ||
This guide is for customers who are building a CrowdStrike Falcon Horizon integration project using the AWS Built-In (ABI) program. It walks you through the process of onboarding your AWS organization with CrowdStrike Falcon Horizon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
guide/content/deployment-steps.md
Outdated
--- | ||
|
||
|
||
## Launch the CloudFormation Template in the Management Account | ||
## Launch the CloudFormation template in the AWS management account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be management account
instead of AWS management account
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe AWS Organizations Management Account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
guide/content/deployment-steps.md
Outdated
|
||
|
||
1. Download the cloudformation template from source: https://<abi-template-location> | ||
2. Launch CloudFormation template in your AWS Control Tower home region. | ||
1. Download the Cloudformation template from the following location: https://<abi-template-location> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kkvinjam - I get a 404 when I try that link. Can you check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link will be functional once we open the repos to public. This can be a placeholder until then. BTW, I would remove the query string from the link and make it like this:
https://raw.githubusercontent.com/aws-ia/cfn-abi-crowdstrike-fcs/main/templates/horizon_init_stack.yaml
@kkvinjam - I committed more updates to the files. I left a comment about not being about to access the link to the template that you provided. |
/do-e2e-tests |
End to end test has been scheduled |
e2e test in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests completed successfully
No description provided.