Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GovCloud Support #56

Merged
merged 20 commits into from
Jul 31, 2024
Merged

GovCloud Support #56

merged 20 commits into from
Jul 31, 2024

Conversation

ryanjpayne
Copy link
Contributor

@ryanjpayne ryanjpayne commented Jun 7, 2024 •
edited
Loading

Changes include:

  • AWS GovCloud Support
  • AWS Commercial to Falcon GovCloud Support
  • Optional Permissions Boundary on IAM Roles
  • Update documentation

@kkvinjam
Copy link
Collaborator

kkvinjam commented Jun 7, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Jun 7, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

kkvinjam
kkvinjam requested changes Jun 10, 2024
View reviewed changes
templates/aws_cspm_cloudformation_eb_comm_gov.json Show resolved Hide resolved
templates/aws_cspm_cloudformation_eb_comm_gov.json Show resolved Hide resolved
templates/aws_cspm_cloudformation_eb_comm_gov.json Show resolved Hide resolved
templates/aws_cspm_cloudformation_eb_comm_gov.json Show resolved Hide resolved
templates/aws_cspm_cloudformation_eb_v2.json Outdated Show resolved Hide resolved
templates/aws_cspm_cloudformation_eb_v2.json Outdated Show resolved Hide resolved
templates/aws_cspm_cloudformation_v2.json Outdated Show resolved Hide resolved
templates/aws_cspm_cloudformation_v2.json Outdated Show resolved Hide resolved
templates/aws_cspm_cloudformation_v2.json Outdated Show resolved Hide resolved
templates/aws_cspm_cloudformation_v2.json Outdated Show resolved Hide resolved
@kkvinjam kkvinjam requested a review from awsdmitry June 10, 2024 17:39
@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Jun 13, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

1 similar comment
@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Jun 19, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@kkvinjam
Copy link
Collaborator

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

Test bed cleanup issue.

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Jun 20, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot previously approved these changes Jul 24, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

awsdmitry
awsdmitry approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@awsdmitry awsdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the stacks in both commercial (to govcloud endpoint) and govcloud. Approved with the caveat that the commercial to govcloud stack must be run in us-east-1 now. Should be noted somewhere in the release notes.

@ryanjpayne
Copy link
Contributor Author

Ran through the stacks in both commercial (to govcloud endpoint) and govcloud. Approved with the caveat that the commercial to govcloud stack must be run in us-east-1 now. Should be noted somewhere in the release notes.

addressed this in latest commit

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

1 similar comment
@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@tbulding
Copy link

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

You are not authorized to run end to end tests

@jaymccon
Copy link

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Jul 29, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@jaymccon
Copy link

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Jul 29, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

This is test platform related issue. Will resume the tests once its fixed.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Jul 31, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@kkvinjam kkvinjam merged commit 7287c5b into aws-ia:main Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-ia-automator-prod aws-ia-automator-prod[bot] aws-ia-automator-prod[bot] approved these changes

@awsdmitry awsdmitry awsdmitry approved these changes

@kkvinjam kkvinjam kkvinjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ryanjpayne @kkvinjam @tlindsay42 @tbulding @jaymccon @awsdmitry