Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Terraform module versions to latest #174

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Starting in v5.4 of the ECS module, enabling ECS exec is just a boolean flag without any additional changes required by users feat: Add support for easily enabling ECS Exec support terraform-aws-modules/terraform-aws-ecs#127
  • The container definition port mapping name and hostPort values are not required so they have been removed
  • The standard module definition requirements have been removed from the pre-commit checks - this is to de-emphasize modules here which also means we can remove the empty variables.tf files
  • Updated and aligned the minimum supported versions of Terraform and the AWS provider to 1.0 and 5.0 respectively
  • The Codepipeline/Codebuild/Codedeploy resources have been moved to their own codepipeline.tf file
  • The module names and configurations have been updated to be consistent throughout the patterns
  • Update queue processing example to use modules and align with the other patterns
  • Replace use of shared Task exec role with service level Tasks exec role. For example - this is incorrect because the secret and SSM param ARNs are passed to the module to scope the Task exec policy to allow access to those values but its only valid if the service creates the service specific Task exec role. The use of the shared role means that potentially other tasks are accessing secrets/SSM params that they should not have access to

Motivation and Context

  • There have been a number of significant updates to the modules and this takes advantage of those improvements
  • Ensure the patterns are consistent and aligned with respect to the conventions used

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

I've tested and validated the following:

  • ec2-examples/
    • core-infra/
    • backend-service/
    • lb-service
  • fargate-examples/
    • core-infra/
    • backend-service/
    • lb-service

@bryantbiggs bryantbiggs requested a review from a team as a code owner November 8, 2023 15:03
@arvindsoni80 arvindsoni80 merged commit 7edbb16 into main Dec 13, 2023
@arvindsoni80 arvindsoni80 deleted the feat/update-module-versions branch December 13, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants