-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudformation waiter to delete operation #811
Conversation
Do you think an extra flag is needed to wait? For our usecase this is perfect without any flags. Right now we trigger a clean, a custom script wait for all the stacks tobe deleted and then run clean up resources to delete any leftover s3buckets/dynamodb etc. But what if someone wants to just trigger the delete I guess something like this will be useful. Any thoughts? |
@gattasrikanth That's a good point, will work on modifying this implementation so user can send it as a parameter like you suggested: taskcat test clean project_name --wait-for-stacks-delete |
@gcasilva Thank you so much for this PR; I'm flipping it to draft while you add the flag; flip it to "ready" when you're... ready :) |
…ormation deletion completion before proceeding
@andrew-glenn @gattasrikanth made the change to last commit so that if user does not add argument -w or --wait-for-delete on test clean it will behave as is today (without waiting for cloudformation deletion to complete), but if they add the argument -w then taskcat will wait for cloudformation deletion to complete before proceeding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Overview
Includes Cloudformation waiter for the delete operation. This is needed when we have a use-case to deploy sequential executions of Taskcat that leverages same set of resources as this could cause conflicts.
This is explained in this Issue: #809
Testing/Steps taken to ensure quality
Tested successfully Taskcat sequential deployment using this forked version
Notes
Optional. Caveats, Alternatives, Other relevant information.
Testing Instructions
How to test this PR Start after checking out this branch (bulleted)