fix: Align creation of k8s namespaces and service account in addons #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorrescogollo
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
atorrescogollo
force-pushed
the
addons-k8s-resources-conditional-creation
branch
from
8f5cd7c
to
3dbe341
Compare
atorrescogollo
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
|
thank you for the PR - this will be resolved in the new addons module https://github.com/aws-ia/terraform-aws-eks-blueprints-addons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some addons support setting
helm_config.create_namespace, but don't support settinghelm_config.create_service_account. This makes disablingcreate_namespaceuseless when the creation of the service account is enabled since the service account can't be created into a non-existent namespace.On the other hand, since Blueprints v5 will have different repositories per addon, I would prefer to manage all Kubernetes resources through a custom ArgoCD app. And then, I want blueprints to only create the IAM roles for IRSA.
For both reasons, this PR will allow conditionally creating namespaces (already supported) and service accounts per addon.
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes