feat: Karpenter eventbridge name_prefix #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
dtherhtun
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
approved these changes
Mar 17, 2023
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add optional Karpenter's Event Bridge rules name prefix not to conflict when we create more than one cluster in the same region.
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes
@askulkarni2 As you wish, I closed the previous PR and update name_prefix and docs as well then here is the new PR for that. [Sorry I misunderstood and here is the PR in the new addons repo - https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/11 ]