chore: Validate karpenter addon using the updated karpenter example
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is going into the |
bryantbiggs
commented
May 2, 2023
| @@ -0,0 +1,99 @@ | |||
| # Karpenter | |||
There was a problem hiding this comment.
This will eventually live in the docs folder of terraform-aws-eks-blueprints-addons when the changes are sync'd back to that repo
bryantbiggs
commented
May 2, 2023
|
|
||
| cluster_name = module.eks.cluster_name | ||
| cluster_endpoint = module.eks.cluster_endpoint | ||
| cluster_version = module.eks.cluster_version | ||
| oidc_provider_arn = module.eks.oidc_provider_arn | ||
|
|
||
| # We want to wait for the Fargate profiles to be deployed first | ||
| create_delay_dependencies = [for prof in module.eks.fargate_profiles : prof.fargate_profile_arn] |
There was a problem hiding this comment.
had to add back in the "hack" - it feels better, not sold on the name yet - just dependencies? wait_dependencies
bryantbiggs
commented
May 2, 2023
| @@ -310,40 +303,3 @@ module "vpc" { | |||
|
|
|||
| tags = local.tags | |||
| } | |||
|
|
|||
| module "ebs_csi_driver_irsa" { | |||
There was a problem hiding this comment.
these aren't relevant to the pattern as it currently stands - removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
karpenteraddon using the updatedkarpenterexampleterraform-aws-eks-blueprints-addonsto speed up testing and validation of both addons and exampleskarpenteraddon which simplifies things for usersMotivation
karpenteraddon implementation and the updatedkarpenterexample for v5More
pre-commit run -awith this PRFor Moderators
Additional Notes