Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Map blueprint readmes into doc generation site #1629

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Map blueprint readmes into doc generation site
  • Update examples to align versions (EKS 1.27, VPC v5.0, provider versions for Kubernetes and Helm)
    • Remove upper bound pin on examples AWS provider (will work with v5.0 of provider now)
  • Remove VPC CNI IRSA role usage from examples - will default to node IAM role for now since those permissions exist

Motivation

  • v5 changes

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner June 3, 2023 14:19
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why pre-commit didn’t trimmed the white spaces on the examples I refactored.

@rodrigobersa rodrigobersa merged commit f365bf9 into refactor/addons-module Jun 3, 2023
@rodrigobersa rodrigobersa deleted the feat/blueprints-docs branch June 3, 2023 15:17
@@ -151,7 +147,7 @@ resource "helm_release" "agones" {

module "vpc" {
source = "terraform-aws-modules/vpc/aws"
version = "~> 4.0"
version = "~> 5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to make this the min version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants