Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Addition of Istio observability add-ons and enabling cross-zone loadbalancing on Ingress NLB #1737

Merged
merged 2 commits into from
Aug 20, 2023
Merged

feat: Addition of Istio observability add-ons and enabling cross-zone loadbalancing on Ingress NLB #1737

merged 2 commits into from
Aug 20, 2023

Conversation

vchintal
Copy link
Contributor

@vchintal vchintal commented Aug 19, 2023 •
edited
Loading

Description

  • Added [jaeger, prometheus, grafana, kiali] observability add-ons
  • Added annotation on the istio-ingress NLB to allow cross-zone loadbalancing

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

@vchintal vchintal requested a review from a team as a code owner August 19, 2023 05:07
@vchintal vchintal temporarily deployed to EKS Blueprints Test August 19, 2023 05:07 — with GitHub Actions Inactive
bryantbiggs
bryantbiggs approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@bryantbiggs bryantbiggs merged commit c33c008 into aws-ia:main Aug 20, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchintal @bryantbiggs