feat: Add blockDeviceMappings fields to support multiple EBS volumes #41
Conversation
BREAKING CHANGE: remove blockDevice fields in helm values
lindarr915
changed the title
|
Relate to the issue #40 |
There was a problem hiding this comment.
@lindarr915 Thanks, I have added one comment. Please make sure this change has been tested locally in your environment. I normally deploy the helm chart changes by pointing to local folder path with the changes.
| blockDevice: | ||
| deviceName: /dev/xvda | ||
| blockDeviceMappings: | ||
| - deviceName: /dev/xvda | ||
| volumeSize: 100Gi |
There was a problem hiding this comment.
Do you need to add ebs: here? Check the docs here https://karpenter.sh/docs/concepts/nodeclasses/#specblockdevicemappings
There was a problem hiding this comment.
Yes, I should have added ebs: here. My local test cases only covers overwriting the default values. Let me fix this.
BREAKING CHANGE: remove blockDevice fields in helm values
| version: 0.0.2 | ||
| appVersion: 0.0.2 |
There was a problem hiding this comment.
Changing this version might not make a difference since we are not publishing these Helm charts. You can keep it as 0.0.1.
I will create a new tag for the Data Add-ons, so that existing blueprints will still work with the old tags, and the new ones will need updating to below.
source = "aws-ia/eks-data-addons/aws"
version = "~> 1.40" There was a problem hiding this comment.
reverted back to 0.0.1
karpenter-resources.tf
Outdated
| @@ -1,6 +1,6 @@ | |||
| locals { | |||
| namespace = "karpenter-resources" | |||
| version = "0.0.1" | |||
| version = "0.0.2" | |||
There was a problem hiding this comment.
you can revert this change to 0.0.1
BREAKING CHANGE: remove blockDevice fields in helm values