Update Sample Apps aws-sdk-call API to optionally uniquely name S3 Buckets #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhlogin
reviewed
Mar 1, 2024
sample-apps/python/django_frontend_service/frontend_service_app/views.py
Show resolved
Hide resolved
zzhlogin
reviewed
Mar 1, 2024
zzhlogin
approved these changes
Mar 1, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Update Sample Apps aws-sdk-call API to optionally uniquely name S3 Buckets
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Update Sample Apps aws-sdk-call API to optionally uniquely name S3 Buckets
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Update Sample Apps aws-sdk-call API to optionally uniquely name S3 Buckets
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Update Sample Apps aws-sdk-call API to optionally uniquely name S3 Buckets
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
79 characters was very agressive and decreased readability. Increase to 120 for a more modern limit. Also applied the linter with python scripts/eachdist.py lint. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
zzhlogin
added a commit
that referenced
this pull request
Sep 13, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
zzhlogin
added a commit
that referenced
this pull request
Sep 17, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Blocker for metric rollup test cases - aws-observability/aws-otel-java-instrumentation#729
Context: We want to update the aws-sdk-call api to take in an identifier (like Pod_IP) and use that in the bucket name (e.g. e2e-test-bucket-name-<Pod_IP>). Then the tests will need to specify this ID in queries that include RemoteTarget dimension.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing:
Build and run app locally. Ensured that IP is optional field and previous logic still works.