Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynatrace metric exporter #143

Merged

Conversation

dyladan
Copy link
Contributor

@dyladan dyladan commented Nov 19, 2020

Description:

  • Add Dynatrace metric exporter to AWS OpenTelemetry distro
  • Add end to end tests following wiki description
  • Add exporter to README list

Link to tracking Issue: n/a

Testing:

Documentation:

/cc @arminru

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #143 (e232429) into main (4a60bd1) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   77.63%   77.92%   +0.29%     
==========================================
  Files           4        4              
  Lines          76       77       +1     
==========================================
+ Hits           59       60       +1     
  Misses          9        9              
  Partials        8        8              
Impacted Files Coverage Δ
pkg/defaultcomponents/defaults.go 76.47% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a60bd1...e232429. Read the comment docs.

Copy link
Contributor

@wyTrivail wyTrivail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mxiamxia
Copy link
Member

Sorry, I merged the New Relic changes and caused another conflict here. Please help to resolve the conflict and I'll merge this PR. Thanks.

@arminru
Copy link
Contributor

arminru commented Nov 24, 2020

@mxiamxia No worries, I just merged the changes again. Thanks!

@arminru
Copy link
Contributor

arminru commented Nov 24, 2020

@mxiamxia @wyTrivail I think all merge conflicts are resolved now, let me know if you need anything else.

@wyTrivail wyTrivail merged commit a0fba3e into aws-observability:main Nov 24, 2020
@arminru arminru deleted the add-dynatrace-exporter branch November 24, 2020 23:00
vastin pushed a commit to vastin/aws-otel-collector that referenced this pull request Mar 3, 2021
The configuration was missing the required options. Presumably this is the reason why
the build of aws-observability#181 failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants