Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buildtool kit for adot collector image #860

Merged
merged 36 commits into from
Jan 11, 2022
Merged

add buildtool kit for adot collector image #860

merged 36 commits into from
Jan 11, 2022

Conversation

khanhntd
Copy link
Contributor

@khanhntd khanhntd commented Jan 6, 2022

Description:

Eliminate docker load and docker save, instead using GitHub Action Build Push Action to support building adot collector image with build.

Link to tracking Issue:
#846

Testing:
Finding a way to test. Currently seeing https://github.com/nektos/act but another potential ways is to use dev branch.

Documentation:
Build Push Action: https://github.com/docker/build-push-action

@khanhntd khanhntd requested a review from a team as a code owner January 6, 2022 20:23
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@alolita alolita requested a review from anuraaga January 7, 2022 03:15
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #860 (24e3b26) into main (94d47a0) will increase coverage by 3.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   50.38%   53.69%   +3.30%     
==========================================
  Files          11       12       +1     
  Lines         385      419      +34     
==========================================
+ Hits          194      225      +31     
- Misses        175      177       +2     
- Partials       16       17       +1     
Impacted Files Coverage Δ
pkg/config/config_factory.go 100.00% <0.00%> (ø)
pkg/config/expand.go 89.28% <0.00%> (ø)
pkg/config/flags.go 85.71% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d47a0...24e3b26. Read the comment docs.

.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
Copy link
Member

@jefchien jefchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/CI.yml Show resolved Hide resolved
@jefchien jefchien merged commit e5751cd into aws-observability:main Jan 11, 2022
@khanhntd khanhntd deleted the support_buildx_docker branch January 11, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants