-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add buildtool kit for adot collector image #860
add buildtool kit for adot collector image #860
Conversation
Codecov Report
@@ Coverage Diff @@
## main #860 +/- ##
==========================================
+ Coverage 50.38% 53.69% +3.30%
==========================================
Files 11 12 +1
Lines 385 419 +34
==========================================
+ Hits 194 225 +31
- Misses 175 177 +2
- Partials 16 17 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Eliminate docker load and docker save, instead using GitHub Action Build Push Action to support building adot collector image with build.
Link to tracking Issue:
#846
Testing:
Finding a way to test. Currently seeing https://github.com/nektos/act but another potential ways is to use dev branch.
Documentation:
Build Push Action: https://github.com/docker/build-push-action