Upgrade OTel dependencies to v0.42.0. #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 50.38% 53.36% +2.97%
==========================================
Files 11 12 +1
Lines 385 416 +31
==========================================
+ Hits 194 222 +28
- Misses 175 177 +2
- Partials 16 17 +1
Continue to review full report at Codecov.
|
Aneurysm9
approved these changes
Jan 7, 2022
khanhntd
approved these changes
Jan 7, 2022
sethAmazon
reviewed
Jan 10, 2022
| @@ -102,21 +100,18 @@ func TestGetMapProviderContainer(t *testing.T) { | |||
| os.Setenv("PPROF_ENDPOINT", expectedEndpoint) | |||
| defer os.Unsetenv("PPROF_ENDPOINT") | |||
|
|
|||
| os.Setenv("AOT_CONFIG_CONTENT", "extensions:\n health_check:\n pprof:\n endpoint: '${PPROF_ENDPOINT}'\nreceivers:\n otlp:\n protocols:\n grpc:\n endpoint: 0.0.0.0:4317\nprocessors:\n batch:\nexporters:\n logging:\n loglevel: debug\n awsxray:\n local_mode: true\n region: 'us-west-2'\n awsemf:\n region: 'us-west-2'\nservice:\n pipelines:\n traces:\n receivers: [prometheusreceiver]\n exporters: [logging,awsxray]\n metrics:\n receivers: [prometheusreceiver]\n exporters: [awsemf]\n extensions: [pprof]") | |||
| defer os.Unsetenv("AOT_CONFIG_CONTENT") | |||
| os.Setenv(envKey, "extensions:\n health_check:\n pprof:\n endpoint: '${PPROF_ENDPOINT}'\nreceivers:\n otlp:\n protocols:\n grpc:\n endpoint: 0.0.0.0:4317\nprocessors:\n batch:\nexporters:\n logging:\n loglevel: debug\n awsxray:\n local_mode: true\n region: 'us-west-2'\n awsemf:\n region: 'us-west-2'\nservice:\n pipelines:\n traces:\n receivers: [otlp]\n exporters: [logging,awsxray]\n metrics:\n receivers: [otlp]\n exporters: [awsemf]\n extensions: [pprof]") | |||
sethAmazon
approved these changes
Jan 10, 2022
|
@Aneurysm9 Do we want to pull in the changes to flags.go (https://github.com/open-telemetry/opentelemetry-collector/blob/v0.42.0/service/flags.go)? Right now, we only allow the config/set flags. Pulling in this change would include 3 additional flags (feature-gates, metrics-addr, metrics-level). |
|
|
jefchien
force-pushed
the
upgrade-v0.42.0
branch
from
f2eac35
to
c87a101
Compare
Aneurysm9
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Re-defined
ExpandConverterfor environment variable expansion in config provider. Fixed tests that broke due to change.Link to tracking Issue: #867
Testing: Ran unit tests and built without issue.