Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added becnhmark workflow on PR #23

Merged
merged 3 commits into from
Feb 14, 2021
Merged

added becnhmark workflow on PR #23

merged 3 commits into from
Feb 14, 2021

Conversation

bhautikpip
Copy link
Contributor

  1. Added benchmark workflow which runs on every PR (idea is to get performance numbers on every released version upstream)

@anuraaga
Copy link
Contributor

I don't think we have any code to benchmark - shouldn't these go upstream?

@anuraaga
Copy link
Contributor

/cc @srprash added the Java ones upstream

@bhautikpip
Copy link
Contributor Author

bhautikpip commented Feb 11, 2021

I don't think we have any code to benchmark - shouldn't these go upstream?

Yes I agree but the current benchmark code we have in this repository is only benchmarking aws specific components. We can definitely have the benchmark upstream but that would require a wide variety of benchmarks as per my understanding (needs more work). This PR is just an enhancement to what we have. Hence I thought of running the benchmark as workflow so at least we get an idea of the performance of released version and if next version needs improvement or not whenever we update sample app version to match the latest upstream version.

@anuraaga
Copy link
Contributor

We should try to add these benchmarks upstream - any benchmark is better than no benchmark, they shouldn't resist that just because it doesn't benchmark every type of component. If there's a problem there, we can consider adding the benchmarks here but I wouldn't expect any issues.

Base automatically changed from master to main February 12, 2021 08:39
@bhautikpip
Copy link
Contributor Author

bhautikpip commented Feb 12, 2021

We should try to add these benchmarks upstream - any benchmark is better than no benchmark, they shouldn't resist that just because it doesn't benchmark every type of component. If there's a problem there, we can consider adding the benchmarks here but I wouldn't expect any issues.

Do you think we should merge this PR or just close this? This PR is just a workflow for already existing benchmarks in this repository. Until we move all the benchmarks exist in this repository to upstream I think merging this PR wouldn't hurt. However I am also fine with closing this out.

@anuraaga
Copy link
Contributor

That's a good point, let's add this workflow but not forget to move the benchmarks upstream.

@bhautikpip
Copy link
Contributor Author

Created issue for tracking this(moving benchmark to upstream) item: #24

@bhautikpip bhautikpip merged commit 3bfbb2c into main Feb 14, 2021
@bhautikpip bhautikpip deleted the benchmark-workflow branch February 14, 2021 02:35
@bhautikpip bhautikpip restored the benchmark-workflow branch February 15, 2021 20:00
@vasireddy99 vasireddy99 deleted the benchmark-workflow branch September 28, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants