-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating workflows #689
Updating workflows #689
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=============================================
- Coverage 85.71% 50.73% -34.99%
- Complexity 19 264 +245
=============================================
Files 3 39 +36
Lines 49 1301 +1252
Branches 5 141 +136
=============================================
+ Hits 42 660 +618
- Misses 3 609 +606
- Partials 4 32 +28 ☔ View full report in Codecov by Sentry. |
@@ -115,24 +99,38 @@ jobs: | |||
test_ref: 'terraform' | |||
caller-workflow-name: 'nightly-upstream-snapshot-build' | |||
|
|||
# E2E tests where SampleApp has Java Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this Test as it builds the sample app with the released upstream dependencies and not with the snapshot one. I think providing this test here, requires much more work to ensure sample apps are build with java agent that have upstream snapshot versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this job recently added to the nightly build workflow? I am having a bit of trouble tracing the git blame back for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I added it recently in this PR. and I realise now it was a mistake, so removing it with this PR.
I think this testing should be part of nightly build, but putting it in nightlybuild
workflows require some prior updates in the repo to facilitate this.
Issue #, if available:
Description of changes:
Fixing this PR: #627
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.