Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating workflows #689

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Updating workflows #689

merged 1 commit into from
Jan 5, 2024

Conversation

PaurushGarg
Copy link
Member

Issue #, if available:

Description of changes:
Fixing this PR: #627

  1. Separate out contract tests for main and nightly build.
  2. Remove patch build for nightlybuild workflow as this workflow should need patching.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PaurushGarg PaurushGarg requested a review from a team as a code owner January 3, 2024 21:35
@codecov-commenter
Copy link

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (fdfb4ab) 50.73%.
Report is 198 commits behind head on main.

Files Patch % Lines
...ent/providers/AwsAppSignalsCustomizerProvider.java 24.00% 35 Missing and 3 partials ⚠️
...gent/providers/AwsSpanMetricsProcessorBuilder.java 0.00% 20 Missing ⚠️
...ders/AttributePropagatingSpanProcessorBuilder.java 0.00% 16 Missing ⚠️
...viders/AwsMetricAttributesSpanExporterBuilder.java 0.00% 11 Missing ⚠️
...try/javaagent/providers/AwsSpanProcessingUtil.java 90.16% 1 Missing and 5 partials ⚠️
...vaagent/providers/AwsMetricAttributeGenerator.java 96.89% 2 Missing and 3 partials ⚠️
...y/javaagent/providers/AwsSpanMetricsProcessor.java 91.48% 0 Missing and 4 partials ⚠️
...t/providers/AttributePropagatingSpanProcessor.java 94.59% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #689       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%     
- Complexity       19      264      +245     
=============================================
  Files             3       39       +36     
  Lines            49     1301     +1252     
  Branches          5      141      +136     
=============================================
+ Hits             42      660      +618     
- Misses            3      609      +606     
- Partials          4       32       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -115,24 +99,38 @@ jobs:
test_ref: 'terraform'
caller-workflow-name: 'nightly-upstream-snapshot-build'

# E2E tests where SampleApp has Java Agent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this Test as it builds the sample app with the released upstream dependencies and not with the snapshot one. I think providing this test here, requires much more work to ensure sample apps are build with java agent that have upstream snapshot versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this job recently added to the nightly build workflow? I am having a bit of trouble tracing the git blame back for it.

Copy link
Member Author

@PaurushGarg PaurushGarg Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I added it recently in this PR. and I realise now it was a mistake, so removing it with this PR.
I think this testing should be part of nightly build, but putting it in nightlybuild workflows require some prior updates in the repo to facilitate this.

@rapphil rapphil merged commit bb2796f into main Jan 5, 2024
4 checks passed
@thpierce thpierce deleted the update-flows branch August 27, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants