Add configuration files for JMX support. #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. |
bjrara
added a commit
that referenced
this pull request
Sep 19, 2024
## Feature request Add runtime metrics collection into Application Signals. ## Description of changes: 1. Add JMX metrics template. 1. The JMX template is taken from #817. The template is updated with bug fixes and added with additional CPU metrics. The author of the original PR is notified with the changes. 2. Introduce `CloudWatchTemporalitySelector` to set temporality of Application Signals exporter to `alwaysDelta`. 3. Add `ScopeBasedPeriodicMetricReader` to copy metrics from `io.opentelemetry.jmx` instrumentation scope to Application Signals exporter. 4. Set `aws.local.service` into resource attributes. ## Result example ``` { resource=Resource{ schemaUrl=https: //opentelemetry.io/schemas/1.21.0, attributes={ aws.local.service="ec2-runtime-demo", cloud.account.id="633750930120", cloud.availability_zone="us-east-1a", cloud.platform="aws_ec2", cloud.provider="aws", cloud.region="us-east-1", host.arch="amd64", host.id="i-03ff80a878a803e0e", host.image.id="ami-0ae8f15ae66fe8cda", host.name="ip-172-31-25-215.ec2.internal", host.type="t2.medium", os.description="Linux 6.1.102-108.177.amzn2023.x86_64", os.type="linux", process.command_args=[ /usr/lib/jvm/java-21-amazon-corretto.x86_64/bin/java, -Dotel.instrumentation.micrometer.enabled=false, -jar, spring-petclinic-all-in-one.jar ], process.executable.path="/usr/lib/jvm/java-21-amazon-corretto.x86_64/bin/java", process.pid=445291, process.runtime.description="Amazon.com Inc. OpenJDK 64-Bit Server VM 21.0.4+7-LTS", process.runtime.name="OpenJDK Runtime Environment", process.runtime.version="21.0.4+7-LTS", service.name="ec2-runtime-demo", service.version="3.1.0-SNAPSHOT", telemetry.auto.version="1.33.0-aws-SNAPSHOT", telemetry.sdk.language="java", telemetry.sdk.name="opentelemetry", telemetry.sdk.version="1.34.1" } }, instrumentationScopeInfo=InstrumentationScopeInfo{ name=io.opentelemetry.jmx, version=null, schemaUrl=null, attributes={ } }, name=jvm.gc.collections.elapsed, description=Theapproximateaccumulatedcollectionelapsedtimeinmilliseconds, unit=ms, type=LONG_SUM, data=ImmutableSumData{ points=[ ImmutableLongPointData{ startEpochNanos=1724126549515601332, epochNanos=1724126609522082935, attributes={ name="G1 Old Generation" }, value=0, exemplars=[ ] }, ImmutableLongPointData{ startEpochNanos=1724126549515601332, epochNanos=1724126609522082935, attributes={ name="G1 Concurrent GC" }, value=49, exemplars=[ ] }, ImmutableLongPointData{ startEpochNanos=1724126549515601332, epochNanos=1724126609522082935, attributes={ name="G1 Young Generation" }, value=332, exemplars=[ ] } ], monotonic=true, aggregationTemporality=CUMULATIVE } } ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
musa-asad
pushed a commit
to musa-asad/aws-otel-java-instrumentation
that referenced
this pull request
Oct 8, 2024
## Feature request Add runtime metrics collection into Application Signals. ## Description of changes: 1. Add JMX metrics template. 1. The JMX template is taken from aws-observability#817. The template is updated with bug fixes and added with additional CPU metrics. The author of the original PR is notified with the changes. 2. Introduce `CloudWatchTemporalitySelector` to set temporality of Application Signals exporter to `alwaysDelta`. 3. Add `ScopeBasedPeriodicMetricReader` to copy metrics from `io.opentelemetry.jmx` instrumentation scope to Application Signals exporter. 4. Set `aws.local.service` into resource attributes. ## Result example ``` { resource=Resource{ schemaUrl=https: //opentelemetry.io/schemas/1.21.0, attributes={ aws.local.service="ec2-runtime-demo", cloud.account.id="633750930120", cloud.availability_zone="us-east-1a", cloud.platform="aws_ec2", cloud.provider="aws", cloud.region="us-east-1", host.arch="amd64", host.id="i-03ff80a878a803e0e", host.image.id="ami-0ae8f15ae66fe8cda", host.name="ip-172-31-25-215.ec2.internal", host.type="t2.medium", os.description="Linux 6.1.102-108.177.amzn2023.x86_64", os.type="linux", process.command_args=[ /usr/lib/jvm/java-21-amazon-corretto.x86_64/bin/java, -Dotel.instrumentation.micrometer.enabled=false, -jar, spring-petclinic-all-in-one.jar ], process.executable.path="/usr/lib/jvm/java-21-amazon-corretto.x86_64/bin/java", process.pid=445291, process.runtime.description="Amazon.com Inc. OpenJDK 64-Bit Server VM 21.0.4+7-LTS", process.runtime.name="OpenJDK Runtime Environment", process.runtime.version="21.0.4+7-LTS", service.name="ec2-runtime-demo", service.version="3.1.0-SNAPSHOT", telemetry.auto.version="1.33.0-aws-SNAPSHOT", telemetry.sdk.language="java", telemetry.sdk.name="opentelemetry", telemetry.sdk.version="1.34.1" } }, instrumentationScopeInfo=InstrumentationScopeInfo{ name=io.opentelemetry.jmx, version=null, schemaUrl=null, attributes={ } }, name=jvm.gc.collections.elapsed, description=Theapproximateaccumulatedcollectionelapsedtimeinmilliseconds, unit=ms, type=LONG_SUM, data=ImmutableSumData{ points=[ ImmutableLongPointData{ startEpochNanos=1724126549515601332, epochNanos=1724126609522082935, attributes={ name="G1 Old Generation" }, value=0, exemplars=[ ] }, ImmutableLongPointData{ startEpochNanos=1724126549515601332, epochNanos=1724126609522082935, attributes={ name="G1 Concurrent GC" }, value=49, exemplars=[ ] }, ImmutableLongPointData{ startEpochNanos=1724126549515601332, epochNanos=1724126609522082935, attributes={ name="G1 Young Generation" }, value=332, exemplars=[ ] } ], monotonic=true, aggregationTemporality=CUMULATIVE } } ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
Is #898 relevant to this one? |
bjrara
approved these changes
Oct 10, 2024
mxiamxia
approved these changes
Oct 10, 2024
Merged
bjrara
pushed a commit
that referenced
this pull request
Nov 1, 2024
*Description of changes:* Adds contract tests to verify the expected behavior of the following changes: - #817 - #898 - #901 Starts up sample apps with the instrumented SDK and verifies that metrics are received for each of the supported JMX target systems. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
1. rules/*.yaml
The JMX Metric Insight and the JMX Metric Gatherer have different pre-defined target systems (activemq, tomcat, etc.) and even different metrics within each shared target system (open-telemetry/opentelemetry-java-instrumentation#9765). This is an effort to unify the metrics being generated by deferring to the Gatherer's definition files.
By placing it in the same path as the JMX Metric Insight resources, the rule files can be overwritten and referred to directly.
This makes it easier for users to specify the target systems via environment variables.
This results in
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.