New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bedrock and bedrockRuntime support. #826

Merged

thpierce merged 7 commits into aws-observability:main from zzhlogin:enablement_bedrock

Jul 9, 2024

Contributor

zzhlogin commented Jun 28, 2024 •

edited

Loading

The PR add new RemoteResourceType and RemoteResourceIdentifier for AWS Bedrock and BedrockRuntime services:

"RemoteResourceType": "AWS::Bedrock::Agent"
"RemoteResourceIdentifier": "<agent_id>"

"RemoteResourceType": "AWS::Bedrock::DataSource"
"RemoteResourceIdentifier": "<datasource_id>"

"RemoteResourceType": "AWS::Bedrock::Guardrail"
"RemoteResourceIdentifier": "<guardrail_id>"

"RemoteResourceType": "AWS::Bedrock::KnowledgeBase"
"RemoteResourceIdentifier": "<knowledgeBase_id>"

"RemoteResourceType": "AWS::Bedrock::Model"
"RemoteResourceIdentifier": "<modelId>"

Testing: E2E test performed to confirm trace, metrics are generated:
Traces:

AWS Java SDK V1:

AWS Java SDK V2:

Metrics:
AWS Java SDK V1:

AWS Java SDK V2:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          Add bedrock and bedrockRuntime support.

2ce0833

zzhlogin requested a review from a team as a code owner

June 28, 2024 18:57

mxiamxia reviewed

View reviewed changes

...ovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsAttributeKeys.java Outdated Show resolved Hide resolved

zzhlogin added 2 commits

July 8, 2024 10:18


          Align with Python

06d874e


          Apply spotless.

01eb413

zzhlogin changed the title ~~Add bedrock and bedrockRuntime support (NOT READY).~~ Add bedrock and bedrockRuntime support.

bjrara approved these changes

View reviewed changes

Member

bjrara left a comment

Please update the PR description to reflect the correct changes.


          Fix naming.

a9ab2d8

bjrara approved these changes

View reviewed changes

thpierce reviewed

View reviewed changes

...ovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsAttributeKeys.java Outdated Show resolved Hide resolved

zzhlogin added 3 commits

July 9, 2024 16:03


          Refine keys name.

c7d0c49


          update comment.

53e87ce


          Trigger workflow: no-op commit

3678a6c

thpierce approved these changes

View reviewed changes

thpierce merged commit 2847ea5 into aws-observability:main

4 checks passed

zzhlogin mentioned this pull request

Bedrock contract test (NOT READY) #848

Closed

mxiamxia mentioned this pull request

Add Bedrock contract tests. #855

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet