Add Application Signals runtime metrics with feature disabled #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vastin
approved these changes
Oct 4, 2024
mxiamxia
approved these changes
Oct 4, 2024
bjrara
added a commit
that referenced
this pull request
Oct 25, 2024
## Feature request Add runtime metrics collection into Application Signals. ## Description of changes: This PR is an umbrella PR to track the ongoing changes for runtime metrics. 1. [Add Application Signals runtime metrics with feature disabled #900](#900) [Merged in main] 2. [feat: Add contract tests for runtime metrics #893](#893) 3. Enable runtime metrics by default By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Reno Seo <renoseo@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request
Add runtime metrics collection into Application Signals.
Description of changes:
This PR is (mostly) equivalent to Add Application Signals runtime metrics #881. The difference is that it disables runtime metrics for now.
We split the core function from feature enablement because there are other ongoing feature developments depending on the changes made by runtime metrics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.