Skip to content

Commit

Permalink
update release
Browse files Browse the repository at this point in the history
  • Loading branch information
pxaws committed Sep 11, 2024
1 parent 3c7f9fe commit a711b51
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 28 deletions.
56 changes: 28 additions & 28 deletions .github/actions/artifacts_build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,41 +66,41 @@ runs:
cd aws-distro-opentelemetry-node-autoinstrumentation
npm pack
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
# - name: Set up QEMU
# uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
# - name: Set up Docker Buildx
# uses: docker/setup-buildx-action@v3

- name: Login to private AWS ECR
if: ${{ inputs.push_image == true || inputs.push_image == 'true' }}
uses: docker/login-action@v3
with:
registry: ${{ inputs.image_registry }}
env:
AWS_REGION: ${{ inputs.aws-region }}
# - name: Login to private AWS ECR
# if: ${{ inputs.push_image == true || inputs.push_image == 'true' }}
# uses: docker/login-action@v3
# with:
# registry: ${{ inputs.image_registry }}
# env:
# AWS_REGION: ${{ inputs.aws-region }}

# Per https://docs.aws.amazon.com/AmazonECR/latest/public/docker-pull-ecr-image.html, it is possible to
# make unauthorized calls to get public ECR images (needed to build the ADOT Node docker image), but
# it can fail if you previously authenticated to a public repo. Adding this step to log out, so we
# ensure we can make unauthenticated call. This is important for making the pr_build workflow run on
# PRs created from forked repos.
- name: Logout of public AWS ECR
shell: bash
run: docker logout public.ecr.aws
# - name: Logout of public AWS ECR
# shell: bash
# run: docker logout public.ecr.aws

- name: Build and push image according to input
uses: docker/build-push-action@v5
with:
push: ${{ inputs.push_image }}
context: .
file: ./Dockerfile
platforms: linux/amd64
tags: ${{ inputs.image_uri_with_tag }}
load: ${{ inputs.load_image }}
# - name: Build and push image according to input
# uses: docker/build-push-action@v5
# with:
# push: ${{ inputs.push_image }}
# context: .
# file: ./Dockerfile
# platforms: linux/amd64
# tags: ${{ inputs.image_uri_with_tag }}
# load: ${{ inputs.load_image }}

- name: Perform image scan
uses: ./.github/actions/image_scan
with:
image-ref: ${{ inputs.image_uri_with_tag }}
severity: 'CRITICAL,HIGH,MEDIUM,LOW,UNKNOWN'
# - name: Perform image scan
# uses: ./.github/actions/image_scan
# with:
# image-ref: ${{ inputs.image_uri_with_tag }}
# severity: 'CRITICAL,HIGH,MEDIUM,LOW,UNKNOWN'
1 change: 1 addition & 0 deletions .github/actions/set_up/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ runs:
uses: actions/setup-node@v4
with:
node-version: ${{ inputs.node_version }}
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies and compile to build directory
shell: bash
Expand Down

0 comments on commit a711b51

Please sign in to comment.