feat: [.NET and JS Feature Parity] Support for new AWS Resources in JS SDK #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: set up gen ai inference attributes for foundational text models…
liustve
commented
Nov 19, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
yiyuan-he
reviewed
Nov 19, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/lambda.ts
Outdated
Show resolved
Hide resolved
|
I think this screenshot for Lamba Event Source Mapping is missing the new attributes:
|
Oh I need to edit how I'm populating the cloudformation attribute. I looked at the python code again and if there's no cfn then you just set it to the the resource identifier. |
Fixed: 
|
…-otel-js-instrumentation into aws_resource_support
yiyuan-he
previously approved these changes
Nov 26, 2024
jj22ee
reviewed
Nov 27, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/lambda.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/sns.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/patches/instrumentation-patch.test.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/patches/instrumentation-patch.test.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Show resolved
Hide resolved
…-otel-js-instrumentation into aws_resource_support
…-otel-js-instrumentation into aws_resource_support
jj22ee
reviewed
Dec 6, 2024
aws-distro-opentelemetry-node-autoinstrumentation/test/patches/aws/services/bedrock.test.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Outdated
Show resolved
Hide resolved
mxiamxia
previously approved these changes
Dec 16, 2024
mxiamxia
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding support for new AWS resources in JS SDK. Part of an ongoing project to increase the ADOT SDK support in Node and .NET.
Changes in this PR support the exact same features as the Python version:
aws-observability/aws-otel-python-instrumentation#265
Manual Testing:
Unit Tests for Instrumentation Patches and Metric Attribute Generators:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.