feat: update propagator and ID generator to support opentelemetry-js 0.12.x #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the help, this is looking great! Indeed we'll need to bump the versions in the integration tests too I think. |
added 2 commits
November 30, 2020 10:52
Also remove some unused dependencies and set private to true in package.json to prevent accidental npm publishes.
mickdekkers
changed the title
|
Happy to help. Thanks for looking at this 😄 I updated the dependencies in the integration tests app but I haven't run it since it doesn't look like the integration tests are intended to be run locally. It looks like the GitHub Actions will deploy the app to AWS so the app can be tested in that environment. |
anuraaga
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Thanks, let's see how it goes! @bhautikpip this makes me thing we need a unit test type of tool to sanity-check sample apps without the whole e2e flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the propagator to support opentelemetry-js 0.12.x, fixing #35:
Also bumps the version of the
@opentelemetry/coredependency for the ID generator package. That interface did not get any breaking changes.I've marked this as a draft for the moment. The unit tests are passing but I haven't looked at the integration tests yet.Update: I updated the integration tests and also the ID generator. Everything should support 0.12.x now 😄