Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase points to alarm for memory usage poll #36

Conversation

NathanielRN
Copy link
Contributor

Description

Synchronizing soak test changes between the languages. For an extended description, see the PR that initiated the changes: aws-observability/aws-otel-dotnet#16

@anuraaga anuraaga merged commit f7374ac into aws-observability:main Oct 11, 2021
@anuraaga
Copy link
Contributor

@NathanielRN By the way, a quick workaround to having a shared action could be using a git submodule to reference the action files

@NathanielRN NathanielRN deleted the increase-points-to-alarm-memory-usage branch October 12, 2021 21:21
@NathanielRN
Copy link
Contributor Author

@anuraaga That's a good point, but we would still have to update the commit reference right? Although, it's probably better than changes with multiple lines of code in multiple repos.

Another issue is getting the repo we need for that I guess. I could use my organization but we'd have to get a ticket going for an aws-observability one. (Unless we just put it into https://github.com/aws-observability/aws-otel-test-framework/ somewhere but ideally not because the goal of these tests is for it to be used by upstream. In which case otel-test-framework would be better).

@anuraaga
Copy link
Contributor

@NathanielRN Yeah I guess since we wouldn't be able take just a folder even with a submodule it wouldn't work to reuse a repo unfortunately.

The burden of the files is pretty high though so an interim before upstream would be quite helpful, including for reviewers I think as that would probably take quite some time. We have this repo

https://github.com/aws-observability/aws-observability-build

which isn't actually used and I don't think there are any plans for it. It'd probably be a great idea to repurpose that for the soak tests code, would just need to ping alolita of that intent I think. Wouldn't need a ticket process for that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants