Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing with Node.js 16 #58

Closed
qhanam opened this issue Dec 1, 2021 · 5 comments · Fixed by #59
Closed

Unit tests failing with Node.js 16 #58

qhanam opened this issue Dec 1, 2021 · 5 comments · Fixed by #59
Assignees

Comments

@qhanam
Copy link
Member

qhanam commented Dec 1, 2021

GitHub is updating Node.js to version 16 in all OS images.

Several unit test suites and unit tests fail when run with Node.js 16:

  • Jest worker encountered 4 child process exceptions, exceeding retry limit
    • CognitoIdentityClient.test.ts
    • BeaconHttpHandler.test.ts
    • StsClient.test.ts
    • Authentication.test.ts
    • CommandQueue.test.ts
  • when a TypeError is thrown then the plugin records the name, message and stack

To reproduce, run npm run test with Node.js 16.

@qhanam
Copy link
Member Author

qhanam commented Dec 1, 2021

@thankyouveryfun
Copy link

I could try to solve this if nobody is on it

@qhanam qhanam self-assigned this Dec 1, 2021
@qhanam
Copy link
Member Author

qhanam commented Dec 1, 2021

Thanks for the offer! I picked this up since it is a CI blocker.

More issues to come...

@anuraaga
Copy link

anuraaga commented Dec 2, 2021

GitHub is updating Node.js to version 16 in all OS images.

Just to confirm, we wouldn't have expected the CI to automatically break since we install a node version, right?

https://github.com/aws-observability/aws-rum-web/blob/main/.github/workflows/ci.yaml#L21

Of course good to fix the build on newer node (and probably can run CI on multiple nodes) but just checking

@qhanam qhanam closed this as completed in #59 Dec 2, 2021
@qhanam
Copy link
Member Author

qhanam commented Dec 2, 2021

Just to confirm, we wouldn't have expected the CI to automatically break since we install a node version, right?

Ah yes you are correct, so the node upgrade is moot. Regardless, this is a bit of a blocker for anyone onboarding using node 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants