Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test promise assertions. #59

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

qhanam
Copy link
Member

@qhanam qhanam commented Dec 1, 2021

Description

Resolve #58

This change fixes handling of rejected promises in Jest tests. Now (1) these tests no longer fail, and (2) when they do fail, the test that failed is visible (instead of the process crashing).

Notes

  • Remove // ts-ignore in modified files
  • Fix test broken by new Node.js error TypeError message format

@qhanam qhanam requested a review from anuraaga December 1, 2021 23:37
@qhanam qhanam self-assigned this Dec 1, 2021
@qhanam qhanam merged commit ee6dd75 into main Dec 2, 2021
@qhanam qhanam deleted the qhanam-devops-nodejs-16 branch December 2, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests failing with Node.js 16
2 participants