Skip to content

Feat: Add support for POWERTOOLS_LOGGER_LOG_EVENT to the logging module #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
AlexeySoshin opened this issue Sep 27, 2023 · 3 comments
Closed
1 of 2 tasks
Assignees
Labels
feature-parity Feature parity with python version priority:3 Neutral - not a core feature or affects less than 40% of users

Comments

@AlexeySoshin
Copy link
Contributor

AlexeySoshin commented Sep 27, 2023

Summary

POWERTOOLS_LOGGER_LOG_EVENT is a flag that exists in the examples, but is not supported by the library. The other libraries support it (e.g., python) so we should too. When we get a Lambda event, if this environment variable is set, we log the event itself. This can be done programatically at the moment.

Why is this needed?

This could confuse engineers that would expect the POWERTOOLS_LOGGER_LOG_EVENT to control the behaviour of the logger somehow.

Which area does this relate to?

Other

Solution

The POWERTOOLS_LOGGER_LOG_EVENT should be implemented.

Acknowledgment

@scottgerring
Copy link
Contributor

Nice catch! Really doesn't seem to be referenced anywhere apart from example deployment code.

@scottgerring scottgerring added bug Something isn't working priority:3 Neutral - not a core feature or affects less than 40% of users labels Sep 28, 2023
@jeromevdl jeromevdl mentioned this issue Oct 6, 2023
3 tasks
@scottgerring scottgerring changed the title Maintenance: Remove POWERTOOLS_LOGGER_LOG_EVENT from the examples Feat: Add support for POWERTOOLS_LOGGER_LOG_EVENT to the logging module Oct 9, 2023
@scottgerring scottgerring added feature-parity Feature parity with python version and removed bug Something isn't working labels Oct 9, 2023
@jeromevdl
Copy link
Contributor

fixed, will be released after tomorrow

Copy link
Contributor

This is now released under 1.18.0 version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-parity Feature parity with python version priority:3 Neutral - not a core feature or affects less than 40% of users
Projects
Status: Backlog
Development

No branches or pull requests

3 participants