Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v2 - fix version #1348

Merged
merged 1 commit into from
Aug 7, 2023
Merged

chore: v2 - fix version #1348

merged 1 commit into from
Aug 7, 2023

Conversation

scottgerring
Copy link
Contributor

Issue #, if available:

Description of changes:

POMs in v2 should be 2.0.0-SNAPSHOT.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring marked this pull request as ready for review August 7, 2023 04:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring changed the title v2: fix version chore: v2 - fix version Aug 7, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2@be04ef8). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1348   +/-   ##
=====================================
  Coverage      ?   77.25%           
  Complexity    ?      559           
=====================================
  Files         ?       68           
  Lines         ?     2194           
  Branches      ?      235           
=====================================
  Hits          ?     1695           
  Misses        ?      427           
  Partials      ?       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring requested a review from mriccia August 7, 2023 09:45
Copy link
Contributor

@mriccia mriccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottgerring scottgerring merged commit 23261c7 into v2 Aug 7, 2023
@scottgerring scottgerring deleted the v2-version branch August 7, 2023 17:39
jeromevdl pushed a commit that referenced this pull request Aug 30, 2023
jeromevdl pushed a commit that referenced this pull request Oct 12, 2023
jeromevdl pushed a commit that referenced this pull request Oct 12, 2023
jeromevdl pushed a commit that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants