Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: array jmespath fail in idempotency module #1420

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: array jmespath fail in idempotency module #1420

merged 1 commit into from
Sep 11, 2023

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available: #1419

Description of changes:

Changed the implementation of BasePersistenceStore#isMissingIdemPotencyKey() to iterate over elements instead of fields.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl assigned jeromevdl and scottgerring and unassigned jeromevdl Sep 5, 2023
@jeromevdl jeromevdl added bug Something isn't working priority:2 High - core feature or affects 60% of the users labels Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring self-requested a review September 7, 2023 07:18
@scottgerring scottgerring linked an issue Sep 7, 2023 that may be closed by this pull request
Bug: using an array for EventKeyJMESPath in idempotency module causes an error #1419
Closed
scottgerring
scottgerring approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Question before we merge - 1/ how did you discover this and 2/ is there anything else in the JMESPath stuff that might be suspicious that jumped out during this change?

@jeromevdl
Copy link
Contributor Author

LGTM Question before we merge - 1/ how did you discover this and 2/ is there anything else in the JMESPath stuff that might be suspicious that jumped out during this change?

@scottgerring, I found this with the workshop we're doing for re:Invent. There are lots of tests but looks like we still don't cover all the branches...

@jeromevdl jeromevdl merged commit 3dfebee into main Sep 11, 2023
@jeromevdl jeromevdl deleted the fix/jmespath_array branch September 11, 2023 15:46
jeromevdl added a commit that referenced this pull request Oct 12, 2023
@jeromevdl
fix #1419 (#1420)
1165a36
@dreamorosi
Copy link
Contributor

Has this been released? We have a TODO item in the workshop about this.

@jeromevdl
Copy link
Contributor Author

Not released yet. In the next one, should be around mid-november.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottgerring scottgerring scottgerring approved these changes

Assignees

@jeromevdl jeromevdl

Labels
bug Something isn't working priority:2 High - core feature or affects 60% of the users size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: using an array for EventKeyJMESPath in idempotency module causes an error
3 participants
@jeromevdl @dreamorosi @scottgerring