Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Deprecate tracing.base.BaseProvider #4105

Closed
2 tasks done
roger-zhangg opened this issue Apr 10, 2024 · 3 comments
Closed
2 tasks done

Maintenance: Deprecate tracing.base.BaseProvider #4105

roger-zhangg opened this issue Apr 10, 2024 · 3 comments
Labels
internal Maintenance changes v3 Features that will be included in Powertools v3.

Comments

@roger-zhangg
Copy link
Member

roger-zhangg commented Apr 10, 2024

Why is this needed?

In PR #2342 we are providing a observability provider friendly tracing provider to deprecate the current X-Ray specific provider tracing.base.baseprovider and tracing.base.BaseSegment. This new provider solution will enable our customer to send traces to Third party observability provider with ease. After #2342 is merged, the current provider will no longer be used in Tracer.

Which area does this relate to?

Tracer

Solution

This Deprecation is straightforward. This provider class is mostly for internal purpose and X-ray only. If there are customers developing their own provider based on this base provider, they will be able to migrate to the new provider proposed in #2342 with few method/class name changes

Acknowledgment

@roger-zhangg roger-zhangg added triage Pending triage from maintainers internal Maintenance changes labels Apr 10, 2024
@roger-zhangg roger-zhangg changed the title Maintenance: Deprecate tracing.base.baseprovider Maintenance: Deprecate tracing.base.BaseProvider Apr 10, 2024
@rubenfonseca
Copy link
Contributor

Thank you for opening this @roger-zhangg ! Adding tags to track it for Powertools v3

@rubenfonseca rubenfonseca added v3 Features that will be included in Powertools v3. and removed triage Pending triage from maintainers labels Apr 11, 2024
@rubenfonseca rubenfonseca moved this from Triage to On hold in Powertools for AWS Lambda (Python) Apr 11, 2024
@rubenfonseca rubenfonseca added this to the Powertools v3 milestone Apr 11, 2024
@leandrodamascena
Copy link
Contributor

We won't deprecate those classes in V3. We will keep as is but instead we'll open doors to new providers.

We can plan to remove this in V4, but wee ned to plan this in advanced.

Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@anafalcao anafalcao moved this from Coming soon to Closed in Powertools for AWS Lambda (Python) Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes v3 Features that will be included in Powertools v3.
Projects
Development

No branches or pull requests

3 participants