Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Remove any specific code for Pydantic v1 #4191

Closed
1 of 2 tasks
leandrodamascena opened this issue Apr 24, 2024 · 2 comments · Fixed by #4305
Closed
1 of 2 tasks

Maintenance: Remove any specific code for Pydantic v1 #4191

leandrodamascena opened this issue Apr 24, 2024 · 2 comments · Fixed by #4305
Labels
internal Maintenance changes v3 Features that will be included in Powertools v3.
Milestone
Powertools v3 (pr...

Comments

@leandrodamascena
Copy link
Contributor

leandrodamascena commented Apr 24, 2024 •
edited
Loading

Why is this needed?

We are working to release Powertools for AWS Lambda (Python) v3 and in this new version we will remove support for Pydantic v1, keeping Pydantic v2 as the only supported version. Our code and tests are full of ifs to ensure both versions work and we need to remove this.

We also need to bump the Pydantic version in pyproject.toml

Which area does this relate to?

Other

Solution

No response

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers internal Maintenance changes labels Apr 24, 2024
@leandrodamascena leandrodamascena mentioned this issue Apr 24, 2024
Closed
2 tasks
@leandrodamascena leandrodamascena added v3 Features that will be included in Powertools v3. and removed triage Pending triage from maintainers labels Apr 24, 2024
@leandrodamascena leandrodamascena moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Apr 24, 2024
@leandrodamascena leandrodamascena added this to the Powertools v3 milestone Apr 24, 2024
@leandrodamascena leandrodamascena mentioned this issue May 9, 2024
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request May 9, 2024 that will close this issue
refactor(general): drop pydantic v1 #4305
Merged
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label May 10, 2024
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions GitHub Actions
Copy link
Contributor

This is now released under 2.38.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label May 17, 2024
@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal Maintenance changes v3 Features that will be included in Powertools v3.
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
Powertools v3 (priority)
Development

Successfully merging a pull request may close this issue.

refactor(general): drop pydantic v1 leandrodamascena/aws-lambda-powertools-python
1 participant
@leandrodamascena