Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Enable middleware functionality for AppSyncResolver #4600

Closed
2 tasks done
TonySherman opened this issue Jun 21, 2024 · 4 comments
Closed
2 tasks done
Labels

Comments

@TonySherman
Copy link
Contributor

Use case

The middleware functionality for the event handler REST APIs provides a really nice way to work with requests but the AppSyncResolver does not have the same API available to it.

Solution/User Experience

Ideally, the AppSyncResolver would have the same dev experience as the REST API middlewares:

app = AppSyncResolver(middlewares=[my_global_middleware])

@app.resolver(type_name="Query", field_name="getTodo", middlewares=[another_middleware])

Alternative solutions

No response

Acknowledgment

@TonySherman TonySherman added feature-request feature request triage Pending triage from maintainers labels Jun 21, 2024
@leandrodamascena leandrodamascena added help wanted Could use a second pair of eyes/hands revisit-in-3-months Requires more customers feedback before making or revisiting a decision and removed triage Pending triage from maintainers labels Aug 11, 2024
@dreamorosi
Copy link
Contributor

Hi @TonySherman, thank you for your patience and apologies for the delay.

This feature is definitely something that we see value in, however at least for now we don't have concrete plans on implementing it.

Before making a decision on prioritization, we would like to get a better sense of customer demand.

For future readers, if you're reading this issue and you're interested in seeing it added to Powertools for AWS, please consider leaving a 👍 to the original post or leave a comment with your use case. Alternatively, if you're not comfortable doing so in public, you can also send us an email at aws-powertools-maintainers@amazon.com using your work email. Every influence counts!

@dreamorosi dreamorosi added the need-customer-feedback Requires more customers feedback before making or revisiting a decision label Jan 28, 2025
@TonySherman
Copy link
Contributor Author

@dreamorosi - Thanks for the response! I think I originally discussed this feature with Heitor a while back. We ended up utilizing pipeline resolvers instead. That seems to be the standard way to do these kind of things with AppSync. So if it helps gauge demand, I'm not even sure I would move from the pipeline resolvers to an AppSync resolver middleware solution within powertools at this time.

@dreamorosi
Copy link
Contributor

Thank you for getting back to me so quickly.

I am glad Heitor was able to help you find a viable alternative. Based on this I will close the issue for now.

If you or any other customer needs this in the future, please feel free to open another issue referencing this one.

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (Python) Jan 29, 2025
@dreamorosi dreamorosi added rejected and removed help wanted Could use a second pair of eyes/hands revisit-in-3-months Requires more customers feedback before making or revisiting a decision need-customer-feedback Requires more customers feedback before making or revisiting a decision labels Jan 29, 2025
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (Python) Jan 29, 2025
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants