docs(parser): APIGatewayProxyEvent to APIGatewayProxyEventModel #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PIGatewayProxyEventModel"
pull-request-size
bot
added
the
size/S
boring-cyborg
bot
added
the
documentation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
heitorlessa
changed the title
heitorlessa
changed the title
|
hey @darnley thank you for helping improve the documentation; it's definitely an oversight we will prevent after moving all snippets to separate files that can be linted. |
35 tasks
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix the built-in model that is responsible for parsing events of API Gateway Proxy v1 to Lambda. Someone write that the built-in model is
aws_lambda_powertools.utilities.data_classes.APIGatewayProxyEvent, but, in fact, the right model for parsing usingevent_parserisaws_lambda_powertools.utilities.parser.models.APIGatewayProxyEventModel.When we try to use the wrong one (
APIGatewayProxyEvent) inevent_parser, it results in an error since it does not inheritsBaseModelfrompydantic.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/utilities/parser.md