fix: split cold start metric from application metrics to prevent duplicate app metrics #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: chore: version bump to 1.3.1 fix(capture_method): should yield inside with (#124) chore: bump version to 1.3.0 (#122) chore(deps): bump prismjs from 1.20.0 to 1.21.0 in /docs chore(deps): bump elliptic from 6.5.2 to 6.5.3 in /docs feat: add parameter utility (#96) chore: bump version to 1.2.0 (#119) feat: add support for tracing of generators using capture_method decorator (#113)
Codecov Report
@@ Coverage Diff @@
## develop #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 698 697 -1
Branches 64 64
=========================================
- Hits 698 697 -1
Continue to review full report at Codecov.
|
to-mc
approved these changes
Aug 22, 2020
Co-authored-by: Tom McCarthy <tmac.se@gmail.com>
…torlessa/aws-lambda-powertools-python into fix/metrics-cold-start-split * 'fix/metrics-cold-start-split' of https://github.com/heitorlessa/aws-lambda-powertools-python: chore: grammar
|
@heitorlessa good idea, the only thing i would note in the change log is that this is a behavior change (kind of a breaking change if people where relying on this before). |
|
I'm on a fence to whether call this a bugfix - I can't see a scenario where a customer would like to have the same business data split into two different metrics, because dimensions were added. That said, I do want to call this out in the Release notes too |
heitorlessa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #125
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.