feat: option to disallow tracer to capture response as metadata #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 697 701 +4
Branches 64 66 +2
=========================================
+ Hits 697 701 +4
Continue to review full report at Codecov.
|
* develop: chore: clarify changelog bugfix vs breaking change chore: remove/correct unnecessary debug logs chore: fix debug log adding unused obj improv: explicitly assert not having ColdStart metric chore: grammar chore: add metrics fix description fix: update cold_start doc to reflect #125 fix: split ColdStart metric to its own EMF blob #125 chore: correct typos
heitorlessa
force-pushed
the
feat/tracer-disallow-response-metadata
branch
from
59c228d to
adfee49
Compare
|
Done - Lemme know if I missed anything else, and whether the docs are explicit enough :) @michaelbrewer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #128
Description of changes:
capture_responseparameter in bothcapture_lambda_handlerandcapture_methoddecorators, by default True for backward compatibility reasonsChecklist
Added examples in the doc, and warning upfront
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.