-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): automatically add area label based on title #1300
chore(ci): automatically add area label based on title #1300
Conversation
@heitorlessa I don't feel confortable having an array of areas in the JS files. Is there a central place anywhere in the repository where we have the canonical list of areas that we could reference instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another papercut crossed from the list o// Thank you!! Tiny typo on metric
vs metrics
only
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Closest we've got now is our new constants.js: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/.github/scripts/constants.js One of the work we should do is to standardize a baseline of labels (90% there) across all Powertools, then make sure they not only stay in sync but is also available across repos to fetch and use in any automation. We don't have that yet. |
I've pulled the known areas into a constant on |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #1009
Summary
Changes
Automatically add the respective
area
label for known areas. The area is derived from the PR title.User experience
When a contributor submits a PR, an
area/xxx
label should be automatically applied if the title mentions a known powertools area.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.