fix(ci): lambda layer workflow release version and conditionals #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(logger): preserve std keys when using custom formatters (#1264)
* chore: add layer project * reduce to 1 region for dev * chore: shorter name for the workflow * fix ignore markdown lint for now * fix: more f strings * ignore mdlint * add reusable workflow for both beta and prod * Update layer/layer/canary/app.py Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com> * Update layer/layer/canary/app.py Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com> * readme review * rephrase canary stack ssm parameter usage * add default RELEASE_TAG_VERSION assignment based on the input (release or manual trigger) * add reference to layer docs * wording * move version trackign arn to canary stack * remove outdated npm caching, add release tag resolution for manual workflow trigger * review: fix layer name and remove dependencies from reusable workflow * remove debug statement, add default working dir * pin versions and hashes for requirements with pip-compile * rename reusable workflow * pass artefact name to the reusable workflow to prevent potential future conflicts Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
boring-cyborg
bot
added
the
github-actions
pull-request-size
bot
added
the
size/M
7 tasks
heitorlessa
suggested changes
Jul 19, 2022
heitorlessa
changed the title
heitorlessa
changed the title
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
heitorlessa
approved these changes
Jul 19, 2022
rubenfonseca
approved these changes
Jul 19, 2022
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Jul 19, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(ci): lambda layer workflow release version and conditionals (aws-powertools#1316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
In this PR we fix few issues with layers we have discovered in last release.
First, we need to make sure to keep the old layer versions, something I have missed during the migration.
Second, there is a case when the release upstream workflow can fail but it will still trigger the layer deployment because the condition is set to
complete, and it can besuccessorfailure. Thus, we need a job conditional to proceed only upon success OR a dispatch event.Changes
RETAINso we can keep the old layer versionsifblock so we can trigger the workflow manually as wellUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.