-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apigateway): update Response class to require status_code only #1560
fix(apigateway): update Response class to require status_code only #1560
Conversation
* develop: chore(deps-dev): bump mypy-boto3-secretsmanager from 1.24.54 to 1.24.83 (aws-powertools#1557) chore(layers): add dummy v2 layer automation
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Codecov ReportBase: 99.73% // Head: 99.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1560 +/- ##
========================================
Coverage 99.73% 99.73%
========================================
Files 124 124
Lines 5718 5718
Branches 651 651
========================================
Hits 5703 5703
Misses 8 8
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Issue number: #1559
Summary
Changes
Honours docstring by making
content_type
andbody
parameters as optional since they already support defaults when built.User experience
Before
After
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.