Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(homepage): introduce POWERTOOLS_DEV env var #1569

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Oct 4, 2022

Issue number: aws-powertools/powertools-lambda#86

Summary

Changes

Please provide a summary of what's being changed

Formally introduces the effects when POWERTOOLS_DEV environment variable is set.

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/index.md

@heitorlessa heitorlessa requested a review from a team as a code owner October 4, 2022 15:49
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for a team October 4, 2022 15:49
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2022
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 4, 2022
docs/index.md Outdated Show resolved Hide resolved
@heitorlessa
Copy link
Contributor Author

Based on @leandrodamascena comments in #1570, I'll enhance this doc with POWERTOOLS_DEBUG after its implementation, and merge it too prior to releasing today.

docs/index.md Outdated Show resolved Hide resolved
@heitorlessa
Copy link
Contributor Author

Addressed all comments from @leandrodamascena. Merging

@heitorlessa heitorlessa merged commit 1c1bca0 into aws-powertools:develop Oct 5, 2022
@heitorlessa heitorlessa deleted the docs/powertools-dev-env-var branch October 5, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant