Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): release docs as alpha when doing a pre-release #1624

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #1618

Summary

Changes

Please provide a summary of what's being changed

This PR adds a new flag to release docs as alpha when doing a pre-release.

User experience

Please share what the user experience looks like before and after this change

When doing a pre-release, the documentation workflow will not override the latest public release.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Oct 20, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2022
@rubenfonseca rubenfonseca linked an issue Oct 20, 2022 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the feature New feature or functionality label Oct 20, 2022
@rubenfonseca rubenfonseca marked this pull request as ready for review October 20, 2022 09:24
@rubenfonseca rubenfonseca requested a review from a team as a code owner October 20, 2022 09:24
@rubenfonseca rubenfonseca requested review from leandrodamascena and heitorlessa and removed request for a team and leandrodamascena October 20, 2022 09:24
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change for consistency on job names.

LGTM otherwise

.github/workflows/on_release_notes.yml Outdated Show resolved Hide resolved
.github/workflows/on_release_notes.yml Outdated Show resolved Hide resolved
.github/workflows/on_release_notes.yml Outdated Show resolved Hide resolved
Co-authored-by: Heitor Lessa <lessa@amazon.nl>
@rubenfonseca rubenfonseca merged commit 11ae5a9 into aws-powertools:v2 Oct 20, 2022
@rubenfonseca rubenfonseca deleted the feat/allow-pre-releases branch October 20, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality github-actions Pull requests that update Github_actions code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Document how to maintain the release process of v1 and v2
2 participants