Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove v2 suffix from SAR apps #1633

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Oct 21, 2022

Issue number: #1618

Summary

Changes

Please provide a summary of what's being changed

Update SAR workflow to point to existing SAR App

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/index.md

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code labels Oct 21, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2022
@github-actions github-actions bot added the bug Something isn't working label Oct 21, 2022
@rubenfonseca rubenfonseca linked an issue Oct 21, 2022 that may be closed by this pull request
2 tasks
@rubenfonseca rubenfonseca marked this pull request as ready for review October 21, 2022 09:59
@rubenfonseca rubenfonseca requested a review from a team as a code owner October 21, 2022 09:59
@rubenfonseca rubenfonseca requested review from mploski and heitorlessa and removed request for a team and mploski October 21, 2022 09:59
@leandrodamascena
Copy link
Contributor

Approved.

@leandrodamascena leandrodamascena merged commit aa39ed2 into aws-powertools:develop Oct 21, 2022
@rubenfonseca rubenfonseca deleted the chore/sar-v2 branch October 21, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Document how to maintain the release process of v1 and v2
2 participants