fix(deps): update build system to poetry-core #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenfonseca
requested review from
leandrodamascena and
heitorlessa
and removed request for
a team
|
No idea why tests are not running here. |
it's because it's not changing any |
heitorlessa
changed the title
boring-cyborg
bot
added
the
dependencies
pull-request-size
bot
added
the
size/L
heitorlessa
approved these changes
Oct 25, 2022
|
Thanks everyone! My two cents from what I've seen in the wild: The switch only involves that and should work out of the box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1646
Summary
Changes
This bumps the build system to use
poetry-core.Please note that I'm way out of my confort zone here, so this PR might not be the right solution for the symptoms.
But locally it fixed the problem for me.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.