Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(homepage): add Pulumi code example #1652

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

pierskarsenbarg
Copy link
Contributor

@pierskarsenbarg pierskarsenbarg commented Oct 25, 2022

Issue number: #1657

Fixes: #1657

Summary

Adding code to deploy lambda functions with the lambda layer added (similar PR for typescript here: aws-powertools/powertools-lambda-typescript#1135)

Changes

Added Pulumi code both for x86 and arm64 lambda functions

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/index.md

@pierskarsenbarg pierskarsenbarg requested a review from a team as a code owner October 25, 2022 16:59
@pierskarsenbarg pierskarsenbarg requested review from rubenfonseca and removed request for a team October 25, 2022 16:59
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 25, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 25, 2022

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@leandrodamascena leandrodamascena added do-not-merge need-issue PRs that are missing related issues labels Oct 25, 2022
@leandrodamascena
Copy link
Contributor

Hello @pierskarsenbarg! Thank you so much for opening this PR. I added the "need-issue" and "do-not-merge" labels because we need an issue for every PR we open.

Don't worry if you don't have time to do it, I can open it on your behalf. I only added the labels so I don't forget about this.

Thank you.

@pierskarsenbarg
Copy link
Contributor Author

I will get that done shortly. Thanks for letting me know

@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Oct 26, 2022
@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for rubenfonseca October 26, 2022 12:20
@leandrodamascena leandrodamascena self-assigned this Oct 26, 2022
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pierskarsenbarg! I made some small changes to fix things. Can you please review and give me your feedback on these changes?

This is an excellent example that will help users adopting AWS/IaC using Pulumi, thank you very much for taking the time to do this. 🥇

docs/index.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@pierskarsenbarg
Copy link
Contributor Author

All the 🤦 here. Thanks for fixing those

@leandrodamascena
Copy link
Contributor

All the facepalm here. Thanks for fixing those

Don't worry! I know some days are really hard when working with software development 😄 .

@pierskarsenbarg
Copy link
Contributor Author

Yes it was definitely one of those days

@leandrodamascena leandrodamascena changed the title Added code to deploy with pulumi docs(homepage): add pulumi code example Oct 26, 2022
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@leandrodamascena leandrodamascena changed the title docs(homepage): add pulumi code example docs(homepage): add Pulumi code example Oct 26, 2022
@pierskarsenbarg
Copy link
Contributor Author

So do I merge this? Do you merge it? What's next?

@leandrodamascena leandrodamascena merged commit 8fd9e0c into aws-powertools:develop Oct 26, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 26, 2022

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@leandrodamascena
Copy link
Contributor

So do I merge this? Do you merge it? What's next?

Yeahhhh! Merged!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add Pulumi code to deploy lambda with powertools layer
2 participants