-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(homepage): add Pulumi code example #1652
docs(homepage): add Pulumi code example #1652
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Hello @pierskarsenbarg! Thank you so much for opening this PR. I added the "need-issue" and "do-not-merge" labels because we need an issue for every PR we open. Don't worry if you don't have time to do it, I can open it on your behalf. I only added the labels so I don't forget about this. Thank you. |
I will get that done shortly. Thanks for letting me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pierskarsenbarg! I made some small changes to fix things. Can you please review and give me your feedback on these changes?
This is an excellent example that will help users adopting AWS/IaC using Pulumi, thank you very much for taking the time to do this. 🥇
All the 🤦 here. Thanks for fixing those |
Don't worry! I know some days are really hard when working with software development 😄 . |
Yes it was definitely one of those days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
So do I merge this? Do you merge it? What's next? |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Yeahhhh! Merged!! |
Issue number: #1657
Fixes: #1657
Summary
Adding code to deploy lambda functions with the lambda layer added (similar PR for typescript here: aws-powertools/powertools-lambda-typescript#1135)
Changes
Added Pulumi code both for x86 and arm64 lambda functions
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/index.md