-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event-handler): add appsync batch resolvers #1998
Merged
leandrodamascena
merged 107 commits into
aws-powertools:develop
from
mploski:fix/1303-appsync-batch-invoke
Jun 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
432093c
update changelog with latest changes
da1e745
Add batch processing to appsync handler
9c5cbd9
Extend router to accept List of events. Add functional test
4793efd
Add e2e tests
e3ca8c5
Add required package
d0fe867
Fix linter checks
bc45703
Refactor appsync resolver
b7a4391
Refactor code to use composition instead of inheritence
e1d2caa
Refactor appsync event handler
b1a49d6
merging from develop
leandrodamascena f201d25
Merge remote-tracking branch 'upstream/develop' into fix/1303-appsync…
leandrodamascena 8fe6a8b
fix style
leandrodamascena 252a796
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena bb87fa3
Merge branch 'develop' into fix/1303-appsync-batch-invoke
heitorlessa 2714b0f
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 986b497
Merge branch 'develop' into fix/1303-appsync-batch-invoke
heitorlessa b21a0a1
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena a96df34
Merge branch 'develop' into fix/1303-appsync-batch-invoke
mploski d5bbd09
Add support for async batch processing
9f8625e
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 659a044
Fixing sonarcloud error
leandrodamascena 13b0bcd
Adding docstring + increasing coverage
leandrodamascena db74f0a
Adding missing test + increasing coverage
leandrodamascena 1acfe6e
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena b19f4d3
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena c0c45c5
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 56ce1fd
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 5ac0e3c
Start writing docs
f248769
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 0d2f7e9
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 5f44a2b
Refactoring examples
leandrodamascena ab7d5b9
Refactoring code + examples + documentation
leandrodamascena 4711cdf
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 50894b9
Moving e2e tests to the right folder
leandrodamascena 3ae6f73
Moving e2e tests to the right folder
leandrodamascena 733b888
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 99b03c5
Adding partial failure
leandrodamascena 32be46c
Adding partial failure
leandrodamascena 4d07d3c
Fixing docstring and examples
leandrodamascena 5644225
Adding documentation about Handling Exceptions
leandrodamascena 78d330b
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 13ac0a1
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena b928996
Fixing docstring
leandrodamascena 45c8a38
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 48ee55f
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 88d2151
Merging from develop
leandrodamascena f81a003
Adding fine grained control when handling exceptions
leandrodamascena 25fff55
Adding fine grained control when handling exceptions
leandrodamascena 5a335f6
Merge branch 'develop' into fix/1303-appsync-batch-invoke
heitorlessa cbe7190
docs: add intro diagram
heitorlessa 38a77e8
Merge branch 'develop' into fix/1303-appsync-batch-invoke
heitorlessa f10a02c
docs: fix wording (Tech debt)
heitorlessa f0c7b36
refactor: use async_ prefix for async code
heitorlessa db6d67d
refactor: move router to a separate file to ease maintenance
heitorlessa 50134fc
refactor: rename BasePublic to BaseRouter
heitorlessa 14635f5
refactor: undo router context composition to reduce complexity and ca…
heitorlessa 774a725
refactor: reduce abstractions, use explicit methods over assignments
heitorlessa e36dd7c
refactor: move registry to a separate file; make it private
heitorlessa 3cddfff
refactor: expand inline if for readability
heitorlessa 17015df
refactor: short circuit upfront, complex after
heitorlessa 54d892b
refactor: simplify arg name
heitorlessa 0ad3383
refactor: add debug statements
heitorlessa eb340ec
fix(docs): use .context instead of previous ._router.context
heitorlessa 7326582
refactor: use kwargs for explicitness
heitorlessa 26353fa
refactor: use return_exceptions=True to reduce call stack
heitorlessa b27d497
chore: add notes on the beauty of return_exceptions
heitorlessa 2a1c785
refactor: append suffix in exceptions
heitorlessa 98a8aff
chore: if over elif in short-circuit
heitorlessa 32fd640
chore: improve logging; glad I learned this new f-string trick
heitorlessa de823a6
chore: fix debug statement location due to null resolvers
heitorlessa 1698778
revert: debug graceful error flag due to non-determinism async
heitorlessa 3e036f9
revert: debug stmt due to mypy; moving elsewhere
heitorlessa 01251bc
docs: docstring resolver (tech debt)
heitorlessa d280742
docs: minimal batch_resolver docstring
heitorlessa 507d854
chore: complete resolver docstring
heitorlessa f213510
Merge branch 'develop' into fix/1303-appsync-batch-invoke
heitorlessa a805ac3
Removing payload exception
be8b056
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 8592194
Updating poetry
90e73d0
merging develop
69fd6ae
Merging from develop
leandrodamascena e14c73f
Merging from develop
leandrodamascena 857375c
Merging from develop
leandrodamascena 9ed003e
Addressing Heitor's feedback
leandrodamascena d039211
Merge branch 'develop' into fix/1303-appsync-batch-invoke
leandrodamascena 84c3590
Refactoring to support aggregate events
leandrodamascena 4493165
Refactoring examples + docs
leandrodamascena a778dcd
Addressing Heitor's feedback
leandrodamascena 615c6d7
Merging from develop
leandrodamascena b0e1e3e
docs: add diagram to visualize n+1 problem
heitorlessa fb631ea
docs: improve wording in lambda invoke
heitorlessa 1ebc157
docs: add diagram where n+1 problem shifts to Lambda runtime
heitorlessa de73d47
docs: add diagram where n+1 problem shifts to Lambda runtime w/ error…
heitorlessa 4414d6b
docs: highlight lambda response for non-errors
heitorlessa 3764819
docs(setup): increase table of contents depth to 5 to help redis and …
heitorlessa 8606136
Adding examples
leandrodamascena 4c84e52
docs: explain N+1 problem and organize content into sub-sections
heitorlessa 06480d4
docs: clean up batch resolvers section; add typing
heitorlessa 925040e
docs: clean up no-aggregate processing section
heitorlessa 2428ebd
docs: clean up raise on error section
heitorlessa 92db4a2
Adding examples
leandrodamascena 8f3af70
docs: clean up async section
heitorlessa bc6cd12
docs: fix highlights, add missing code annotation
heitorlessa a4173e0
docs: rename snippets to match advanced section
heitorlessa ba173b3
Merge branch 'develop' into fix/1303-appsync-batch-invoke
heitorlessa 5d3616a
Merging from develop
leandrodamascena a612e38
Tests
leandrodamascena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you break the assertions for sync first, then async, and add more details on GIVEN/WHEN as we're doing two tests here, plz?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done