-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add flush_metrics() method to allow manual flushing of metrics #2171
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
79433b2
feat(metrics): add flush_metrics
rubenfonseca 9c7e562
chore: address feedback
rubenfonseca 0238c6a
Update examples/metrics/src/flush_metrics.py
rubenfonseca 18cc5e4
Update examples/metrics/src/flush_metrics.py
rubenfonseca d10d371
fix: highlight
rubenfonseca 6b8e4a1
chore(docs): line editing
leandrodamascena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 10 additions & 6 deletions
16
examples/metrics/src/manual_flush.py → examples/metrics/src/flush_metrics.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,18 @@ | ||
import json | ||
|
||
from aws_lambda_powertools import Metrics | ||
from aws_lambda_powertools.metrics import MetricUnit | ||
from aws_lambda_powertools.utilities.typing import LambdaContext | ||
|
||
metrics = Metrics() | ||
|
||
|
||
def lambda_handler(event: dict, context: LambdaContext): | ||
def book_flight(flight_id: str, **kwargs): | ||
# logic to book flight | ||
... | ||
metrics.add_metric(name="SuccessfulBooking", unit=MetricUnit.Count, value=1) | ||
your_metrics_object = metrics.serialize_metric_set() | ||
metrics.clear_metrics() | ||
print(json.dumps(your_metrics_object)) | ||
|
||
|
||
def lambda_handler(event: dict, context: LambdaContext): | ||
rubenfonseca marked this conversation as resolved.
Show resolved
Hide resolved
|
||
try: | ||
book_flight(flight_id=event.get("flight_id", "")) | ||
finally: | ||
metrics.flush_metrics() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example file was not being used in the documentation, so I just changed the content and started using it.