-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_source): add support for dynamic partitions in the Api Gateway Authorizer event #2176
Conversation
CN partition adaption Signed-off-by: leif ye <94335271+leif-ye@users.noreply.github.com>
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2176 +/- ##
========================================
Coverage 97.46% 97.46%
========================================
Files 147 147
Lines 6875 6876 +1
Branches 505 505
========================================
+ Hits 6701 6702 +1
Misses 137 137
Partials 37 37
☔ View full report in Codecov by Sentry. |
Hello @leif-ye! Thanks for submitting this PR to add CN partition support for this event source. Part of our automation failed because according to our contributing guide, the PR title must follow the conventional semantic title and every PR must also have an issue. But don't worry if you can't fix these minor problems, I can do this when reviewing this PR. I hope you have a great day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @leif-ye!
LGTM!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
CN partition adaption
Issue number: #2177
Summary
CN partition adaption
Changes
Change partition hard code
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.